Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove workaround code in debugger test #39238

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 2, 2021

Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: nodejs/node-inspect#35

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2021
@Trott
Copy link
Member Author

Trott commented Jul 2, 2021

Stress test on AIX: https://ci.nodejs.org/job/node-stress-single-test/300/

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 2, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott requested a review from jkrems July 5, 2021 01:22
Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: nodejs/node-inspect#35

PR-URL: nodejs#39238
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@Trott Trott force-pushed the preserve-breaks branch from d98ca4a to 12622c5 Compare July 6, 2021 04:18
@Trott
Copy link
Member Author

Trott commented Jul 6, 2021

Landed in 12622c5

@Trott Trott merged commit 12622c5 into nodejs:master Jul 6, 2021
@Trott Trott deleted the preserve-breaks branch July 6, 2021 04:23
targos pushed a commit that referenced this pull request Jul 11, 2021
Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: nodejs/node-inspect#35

PR-URL: #39238
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: nodejs/node-inspect#35

PR-URL: #39238
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants